]> git.proxmox.com Git - mirror_qemu.git/commit
slirp: Don't mark struct ipq or struct ipasfrag as packed
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 22 Jan 2019 18:18:22 +0000 (18:18 +0000)
committerSamuel Thibault <samuel.thibault@ens-lyon.org>
Thu, 7 Feb 2019 13:49:08 +0000 (15:49 +0200)
commitaaa0c642b1de62d5a69b6d4bfdaa91e4b65c5518
tree03d43728a764d2b48c67ebc433ec18d672ad9160
parentc74e3ae9c83750705abaa583b28741d349364561
slirp: Don't mark struct ipq or struct ipasfrag as packed

There is no reason to mark the struct ipq and struct ipasfrag as
packed: they are naturally aligned anyway, and are not representing
any on-the-wire packet format.  Indeed they vary in size depending on
the size of pointers on the host system, because the 'struct qlink'
members include 'void *' fields.

Dropping the 'packed' annotation fixes clang -Waddress-of-packed-member
warnings and probably lets the compiler generate better code too.

The only thing we do care about in the layout of the struct is
that the frag_link matches up with the ipf_link of the struct
ipasfrag, as documented in the comment on that struct; assert
at build time that this is the case.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
slirp/ip.h