]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
batman-adv: wait for rtnl in batadv_store_mesh_iface instead of failing if it is...
authorMatthias Schiffer <mschiffer@universe-factory.net>
Tue, 28 May 2013 15:32:32 +0000 (17:32 +0200)
committerAntonio Quartulli <ordex@autistici.org>
Mon, 10 Jun 2013 06:42:16 +0000 (08:42 +0200)
commitac16d1484efd5d2d9077c55453b1f8abff49fc18
tree55c19412cafbd5021082a7faa923b285c33bfee7
parent40edeff6e1c6f9a6f16536ae3375e3af9d648449
batman-adv: wait for rtnl in batadv_store_mesh_iface instead of failing if it is taken

The rtnl_lock in batadv_store_mesh_iface has been converted to a rtnl_trylock
some time ago to avoid a possible deadlock between rtnl and s_active on removal
of the sysfs nodes.

The behaviour introduced by that was quite confusing as it could lead to the
sysfs store to fail, making batman-adv setup scripts unreliable. As recently the
sysfs removal was postponed to a worker not running with the rtnl taken, the
deadlock can't occur any more and it is safe to change the trylock back to a
lock to make the sysfs store reliable again.

Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Reviewed-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
net/batman-adv/sysfs.c