]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
rq-qos: use a mb for got_token
authorJosef Bacik <josef@toxicpanda.com>
Tue, 16 Jul 2019 20:19:29 +0000 (16:19 -0400)
committerJens Axboe <axboe@kernel.dk>
Thu, 18 Jul 2019 16:20:14 +0000 (10:20 -0600)
commitac38297f7038cd5b80d66f8809c7bbf5b70031f3
tree2144d14a14682be1c068249731f6edcfda9e4ff4
parentd14a9b389a86a5154b704bc88ce8dd37c701456a
rq-qos: use a mb for got_token

Oleg noticed that our checking of data.got_token is unsafe in the
cleanup case, and should really use a memory barrier.  Use a wmb on the
write side, and a rmb() on the read side.  We don't need one in the main
loop since we're saved by set_current_state().

Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-rq-qos.c