]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
media: cec-pin: fix broken tx_ignore_nack_until_eom error injection
authorHans Verkuil <hverkuil@xs4all.nl>
Wed, 14 Nov 2018 08:37:53 +0000 (03:37 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 23 Nov 2018 10:48:44 +0000 (05:48 -0500)
commitac791f19a273a7fe254a7596f193af6534582a9f
tree5d363ef009753afb127129cb5a74db5c6de3470a
parent02e6d2eaa9c3f7dc04d67b5a37e17716fa019033
media: cec-pin: fix broken tx_ignore_nack_until_eom error injection

If the tx_ignore_nack_until_eom error injection was activated,
then tx_nacked was never set instead of setting it when the last
byte of the message was transmitted.

As a result the transmit was marked as OK, when it should have
been NACKed.

Modify the condition so that it always sets tx_nacked when the
last byte of the message was transmitted.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Cc: <stable@vger.kernel.org> # for v4.17 and up
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/cec/cec-pin.c