]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
igb: fix deadlock caused by taking RTNL in RPM resume path
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 20 Dec 2021 20:18:44 +0000 (12:18 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 21 Dec 2021 02:48:09 +0000 (18:48 -0800)
commitac8c58f5b535d6272324e2b8b4a0454781c9147e
treed09a5059eaf60fb6c4b769c67e3db2a544bf6edd
parent1f06f7d97f741667bab0f459a4f940b21cab1549
igb: fix deadlock caused by taking RTNL in RPM resume path

Recent net core changes caused an issue with few Intel drivers
(reportedly igb), where taking RTNL in RPM resume path results in a
deadlock. See [0] for a bug report. I don't think the core changes
are wrong, but taking RTNL in RPM resume path isn't needed.
The Intel drivers are the only ones doing this. See [1] for a
discussion on the issue. Following patch changes the RPM resume path
to not take RTNL.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=215129
[1] https://lore.kernel.org/netdev/20211125074949.5f897431@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/t/

Fixes: bd869245a3dc ("net: core: try to runtime-resume detached device in __dev_open")
Fixes: f32a21376573 ("ethtool: runtime-resume netdev parent before ethtool ioctl ops")
Tested-by: Martin Stolpe <martin.stolpe@gmail.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://lore.kernel.org/r/20211220201844.2714498-1-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/igb/igb_main.c