]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
staging: dgrp: fix potential call to strncpy with a negative number
authorBill Pemberton <wfp5p@virginia.edu>
Mon, 24 Sep 2012 21:02:08 +0000 (17:02 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Sep 2012 22:42:38 +0000 (15:42 -0700)
commitad0c6e367ee0d08c4caa19ad0dbd3d752bd39de0
treeefdf83f1ab62b3e4d82670a4920fa373b113d2a1
parent142e5460a66edbfe881474eb422e86ff61c4bfc7
staging: dgrp: fix potential call to strncpy with a negative number

In dgrp_receive() there is:

   desclen = ((plen - 12) > MAX_DESC_LEN) ? MAX_DESC_LEN :
                     plen - 12;
   strncpy(nd->nd_ps_desc, b + 12, desclen);

However, it's possible for plen to be <= 12 here so we'd be passing a
negative number into the strncpy().  Fix this to not make the strncpy
call and report an error if desclen is <= 0

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgrp/dgrp_net_ops.c