]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
media: staging/intel-ipu3: Fix set_fmt error handling
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 10 Mar 2021 00:16:46 +0000 (01:16 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 6 Apr 2021 12:32:39 +0000 (14:32 +0200)
commitad91849996f9dd79741a961fd03585a683b08356
treebf8ffa1de3e684deb98d795f413eaa26051c28c5
parent7120734f41b36daf615ae98c36033b0a379c303f
media: staging/intel-ipu3: Fix set_fmt error handling

If there in an error during a set_fmt, do not overwrite the previous
sizes with the invalid config.

Without this patch, v4l2-compliance ends up allocating 4GiB of RAM and
causing the following OOPs

[   38.662975] ipu3-imgu 0000:00:05.0: swiotlb buffer is full (sz: 4096 bytes)
[   38.662980] DMA: Out of SW-IOMMU space for 4096 bytes at device 0000:00:05.0
[   38.663010] general protection fault: 0000 [#1] PREEMPT SMP

Cc: stable@vger.kernel.org
Fixes: 6d5f26f2e045 ("media: staging/intel-ipu3-v4l: reduce kernel stack usage")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/ipu3/ipu3-v4l2.c