]> git.proxmox.com Git - mirror_qemu.git/commit
vl: Set errp to &error_abort on machine compat_props
authorEduardo Habkost <ehabkost@redhat.com>
Wed, 15 Jun 2016 19:00:01 +0000 (16:00 -0300)
committerEduardo Habkost <ehabkost@redhat.com>
Thu, 7 Jul 2016 18:24:55 +0000 (15:24 -0300)
commitadae837d40dea7100040136647e3de44898994df
treeb94f4b1e0bdd8ac26246d3daac9680b5534fae6e
parent39a3b377b89506ad15b8bc91fe2296f65b9f755a
vl: Set errp to &error_abort on machine compat_props

Use the new GlobalProperty.errp field to handle compat_props
errors.

Example output before this change:
(with an intentionally broken entry added to PC_COMPAT_1_3 just
for testing)

  $ qemu-system-x86_64 -machine pc-1.3
  qemu-system-x86_64: hw/core/qdev-properties.c:1091: qdev_prop_set_globals_for_type: Assertion `prop->user_provided' failed.
  Aborted (core dumped)

After:

  $ qemu-system-x86_64 -machine pc-1.3
  Unexpected error in x86_cpuid_set_vendor() at /home/ehabkost/rh/proj/virt/qemu/target-i386/cpu.c:1688:
  qemu-system-x86_64: can't apply global cpu.vendor=x: Property '.vendor' doesn't take value 'x'
  Aborted (core dumped)

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
hw/core/machine.c