]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
media: ddbridge: fix impossible condition warning
authorDaniel Scheller <d.scheller@gmx.net>
Sat, 12 Aug 2017 11:55:59 +0000 (07:55 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 11:08:31 +0000 (07:08 -0400)
commitadb57f60ace633f1ac78cd4e90b7381a9b5abd12
treee17f88823e2bd5f6990ad56403ae632ae1a0abb7
parent1bdafdf02711c18b54e4d981b96dc0abe9503668
media: ddbridge: fix impossible condition warning

Smatch and gcc complained:

  drivers/media/pci/ddbridge/ddbridge-core.c:3491 bpsnr_show() warn: impossible condition '(snr[0] == 255) => ((-128)-127 == 255)'

  drivers/media/pci/ddbridge/ddbridge-core.c: In function ‘bpsnr_show’:
  drivers/media/pci/ddbridge/ddbridge-core.c:3491:13: warning: comparison is always false due to limited range of data type [-Wtype-limits]

Fix this by changing the type of snr to unsigned char.

Cc: Ralph Metzler <rjkm@metzlerbros.de>
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Tested-by: Richard Scobie <r.scobie@clear.net.nz>
Tested-by: Jasmin Jessich <jasmin@anw.at>
Tested-by: Dietmar Spingler <d_spingler@freenet.de>
Tested-by: Manfred Knick <Manfred.Knick@t-online.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/ddbridge/ddbridge-core.c