]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
clkdev: Update clkdev id usage to allow for longer names
authorMichael J. Ruhl <michael.j.ruhl@intel.com>
Fri, 23 Feb 2024 20:25:56 +0000 (15:25 -0500)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Fri, 2 Aug 2024 14:26:57 +0000 (16:26 +0200)
commitadd5cb3660dbd8444896d8707fc410ce8f72ab85
tree56bf6a0c5be0759ec3073ee684bfb60c17f9daf2
parentae7fe950e11665d81d06bb0ab0ba0fb3e826af86
clkdev: Update clkdev id usage to allow for longer names

BugLink: https://bugs.launchpad.net/bugs/2074091
commit 99f4570cfba1e60daafde737cb7e395006d719e6 upstream.

clkdev DEV ID information is limited to an array of 20 bytes
(MAX_DEV_ID).  It is possible that the ID could be longer than
that.  If so, the lookup will fail because the "real ID" will
not match the copied value.

For instance, generating a device name for the I2C Designware
module using the PCI ID can result in a name of:

i2c_designware.39424

clkdev_create() will store:

i2c_designware.3942

The stored name is one off and will not match correctly during probe.

Increase the size of the ID to allow for a longer name.

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Link: https://lore.kernel.org/r/20240223202556.2194021-1-michael.j.ruhl@intel.com
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
drivers/clk/clkdev.c