]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
vdpa: Add max vqp attr to vdpa_nl_policy for nlattr length check
authorLin Ma <linma@zju.edu.cn>
Thu, 27 Jul 2023 17:57:52 +0000 (20:57 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 30 Oct 2023 11:00:16 +0000 (12:00 +0100)
commitae2717877232fd865ea13a7abb97a8be3427784d
tree1c4086b68911fd83b1d53c891fa287aaf9740558
parenta92c1aeca27321980a1a8af708ce93c88fef8d54
vdpa: Add max vqp attr to vdpa_nl_policy for nlattr length check

BugLink: https://bugs.launchpad.net/bugs/2039110
commit 5d6ba607d6cb5c58a4ddf33381e18c83dbb4098f upstream.

The vdpa_nl_policy structure is used to validate the nlattr when parsing
the incoming nlmsg. It will ensure the attribute being described produces
a valid nlattr pointer in info->attrs before entering into each handler
in vdpa_nl_ops.

That is to say, the missing part in vdpa_nl_policy may lead to illegal
nlattr after parsing, which could lead to OOB read just like CVE-2023-3773.

This patch adds the missing nla_policy for vdpa max vqp attr to avoid
such bugs.

Fixes: ad69dd0bf26b ("vdpa: Introduce query of device config layout")
Signed-off-by: Lin Ma <linma@zju.edu.cn>
Cc: stable@vger.kernel.org
Message-Id: <20230727175757.73988-7-dtatulea@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/vdpa/vdpa.c