]> git.proxmox.com Git - mirror_qemu.git/commit
aio-posix: fix test-aio /aio/event/wait with fdmon-io_uring
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 2 Apr 2020 14:54:34 +0000 (15:54 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 3 Apr 2020 11:42:40 +0000 (12:42 +0100)
commitae60ab7eb20715fa63cca1b0bb4493e160da51ce
treee19eab742f3b336e2ee94dd8dce08e6db31ceb95
parent5142ca078d1cbc0f77b0f385d28cdb3e504e62bd
aio-posix: fix test-aio /aio/event/wait with fdmon-io_uring

When a file descriptor becomes ready we must re-arm POLL_ADD.  This is
done by adding an sqe to the io_uring sq ring.  The ->need_wait()
function wasn't taking pending sqes into account and therefore
io_uring_submit_and_wait() was not being called.  Polling for cqes
failed to detect fd readiness since we hadn't submitted the sqe to
io_uring.

This patch fixes the following tests/test-aio -p /aio/event/wait
failure:

  ok 11 /aio/event/wait
  **
  ERROR:tests/test-aio.c:374:test_flush_event_notifier: assertion failed: (aio_poll(ctx, false))

Reported-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Tested-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200402145434.99349-1-stefanha@redhat.com
Fixes: 73fd282e7b6dd4e4ea1c3bbb3d302c8db51e4ccf
       ("aio-posix: add io_uring fd monitoring implementation")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
util/fdmon-io_uring.c