]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
fs: Call d_automount with the filesystems creds
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 23 Jul 2016 16:20:44 +0000 (11:20 -0500)
committerEric W. Biederman <ebiederm@xmission.com>
Sat, 23 Jul 2016 19:51:26 +0000 (14:51 -0500)
commitaeaa4a79ff6a5ed912b7362f206cf8576fca538b
treecfdd5207fef5e23cf7dc84691cd3301faa9688ec
parent81754357770ebd900801231e7bc8d151ddc00498
fs: Call d_automount with the filesystems creds

Seth Forshee reported a mount regression in nfs autmounts
with "fs: Add user namespace member to struct super_block".

It turns out that the assumption that current->cred is something
reasonable during mount while necessary to improve support of
unprivileged mounts is wrong in the automount path.

To fix the existing filesystems override current->cred with the
init_cred before calling d_automount and restore current->cred after
d_automount completes.

To support unprivileged mounts would require a more nuanced cred
selection, so fail on unprivileged mounts for the time being.  As none
of the filesystems that currently set FS_USERNS_MOUNT implement
d_automount this check is only good for preventing future problems.

Fixes: 6e4eab577a0c ("fs: Add user namespace member to struct super_block")
Tested-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
fs/namei.c