]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
m68k: mac: Don't send IOP message until channel is idle
authorFinn Thain <fthain@telegraphics.com.au>
Sat, 30 May 2020 23:12:13 +0000 (09:12 +1000)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 13 Jul 2020 09:39:13 +0000 (11:39 +0200)
commitaeb445bf2194d83e12e85bf5c65baaf1f093bd8f
treed74b3c152f2cf88c6c9275da2e885e5f3c077dc6
parentbe1a31283655105606407502800871b9c1a1132f
m68k: mac: Don't send IOP message until channel is idle

In the following sequence of calls, iop_do_send() gets called when the
"send" channel is not in the IOP_MSG_IDLE state:

iop_ism_irq()
iop_handle_send()
(msg->handler)()
iop_send_message()
iop_do_send()

Avoid this by testing the channel state before calling iop_do_send().

When sending, and iop_send_queue is empty, call iop_do_send() because
the channel is idle. If iop_send_queue is not empty, iop_do_send() will
get called later by iop_handle_send().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Stan Johnson <userm57@yahoo.com>
Cc: Joshua Thompson <funaho@jurai.org>
Link: https://lore.kernel.org/r/6d667c39e53865661fa5a48f16829d18ed8abe54.1590880333.git.fthain@telegraphics.com.au
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
arch/m68k/mac/iop.c