]> git.proxmox.com Git - mirror_qemu.git/commit
i386:acpi: Remove _HID from the SMBus ACPI entry
authorCorey Minyard <cminyard@mvista.com>
Mon, 20 Jan 2020 17:07:25 +0000 (11:07 -0600)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 22 Jan 2020 06:47:55 +0000 (01:47 -0500)
commitaefcaf9d1b3ebb30981627bd08f595211a648a62
tree14dfc55561f11d812d6a560e922d2231888e4c30
parent76525114736e8f669766e69b715fa59ce8648aae
i386:acpi: Remove _HID from the SMBus ACPI entry

Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required
on enumerated buses (like PCI in this case), _ADR is required (and is
already there).  And the _HID value is wrong.  Linux appears to ignore
the _HID entry, but Windows 10 detects it as 'Unknown Device' and there
is no driver available.  See https://bugs.launchpad.net/qemu/+bug/1856724

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200120170725.24935-6-minyard@acm.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/i386/acpi-build.c
tests/data/acpi/q35/DSDT
tests/data/acpi/q35/DSDT.acpihmat
tests/data/acpi/q35/DSDT.bridge
tests/data/acpi/q35/DSDT.cphp
tests/data/acpi/q35/DSDT.dimmpxm
tests/data/acpi/q35/DSDT.ipmibt
tests/data/acpi/q35/DSDT.memhp
tests/data/acpi/q35/DSDT.mmio64
tests/data/acpi/q35/DSDT.numamem