]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: hda/realtek - Reduce click noise on Dell Precision 5820 headphone
authorTakashi Iwai <tiwai@suse.de>
Mon, 13 May 2019 11:48:00 +0000 (13:48 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 24 Jun 2019 14:21:33 +0000 (16:21 +0200)
commitb001f661a4156c364e5e6233dad8a7fc8e63ce78
treec3db29260c82c3c955e385f22997065dc67c4155
parent0938dca2fb4ef20c593a60e8995d49cd93acceb0
ALSA: hda/realtek - Reduce click noise on Dell Precision 5820 headphone

BugLink: https://bugs.launchpad.net/bugs/1828798
Dell Precision 5820 with ALC3234 codec (which is equivalent with
ALC255) shows click noises at (runtime) PM resume on the headphone.
The biggest source of the noise comes from the cleared headphone pin
control at resume, which is done via the standard shutup procedure.

Although we have an override of the standard shutup callback to
replace with NOP, this would skip other needed stuff (e.g. the pull
down of headset power).  So, instead, this "fixes" the behavior of
alc_fixup_no_shutup() by introducing spec->no_shutup_pins flag.
When this flag is set, Realtek codec won't call the standard
snd_hda_shutup_pins() & co.  Now alc_fixup_no_shutup() just sets this
flag instead of overriding spec->shutup callback itself.  This allows
us to apply the similar fix for other entries easily if needed in
future.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(backported from commit c0ca5eced22215c1e03e3ad479f8fab0bbb30772)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Acked-By: AceLan Kao <acelan.kao@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
sound/pci/hda/patch_realtek.c