]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
s390/qeth: Fix vnicc_is_in_use if rx_bcast not set
authorAlexandra Winter <wintera@linux.ibm.com>
Mon, 23 Dec 2019 14:03:24 +0000 (15:03 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 06:00:53 +0000 (01:00 -0500)
commitb00b4b066178abec1b2dc8e0d91c33d8792d65b0
tree849eb7dac3ad681a167fb6b372442d4270a1829b
parent6a6ea1641c79a5753c57bbcd46b56843f576eb17
s390/qeth: Fix vnicc_is_in_use if rx_bcast not set

BugLink: https://bugs.launchpad.net/bugs/1862227
commit e8a66d800471e2df7f0b484e2e46898b21d1fa82 upstream.

Symptom: After vnicc/rx_bcast has been manually set to 0,
bridge_* sysfs parameters can still be set or written.
Only occurs on HiperSockets, as OSA doesn't support changing rx_bcast.

Vnic characteristics and bridgeport settings are mutually exclusive.
rx_bcast defaults to 1, so manually setting it to 0 should disable
bridge_* parameters.

Instead it makes sense here to check the supported mask. If the card
does not support vnicc at all, bridge commands are always allowed.

Fixes: caa1f0b10d18 ("s390/qeth: add VNICC enable/disable support")
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/s390/net/qeth_l2_main.c