]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
loop: fix error handling regression
authorArnd Bergmann <arnd@arndb.de>
Fri, 9 Jun 2017 10:19:18 +0000 (12:19 +0200)
committerJens Axboe <axboe@fb.com>
Fri, 9 Jun 2017 14:18:42 +0000 (08:18 -0600)
commitb040ad9cf6a169cc000a5324fcada695dfa1f4b3
treecb1d3664599b8acdb17816467919c06b8cf4b04c
parentf2c6df7dbf9a60e1cd9941f9fb376d4d9ad1e8dd
loop: fix error handling regression

gcc points out an unusual indentation:

drivers/block/loop.c: In function 'loop_set_status':
drivers/block/loop.c:1149:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
   if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
   ^~
drivers/block/loop.c:1152:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    goto exit;

This was introduced by a new feature that accidentally moved the opening
braces from one condition to another. Adding a second pair of braces
makes it work correctly again and also more readable.

Fixes: f2c6df7dbf9a ("loop: support 4k physical blocksize")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/loop.c