]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
umh: Move setting PF_UMH into umh_pipe_setup
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 25 Jun 2020 15:04:25 +0000 (10:04 -0500)
committerEric W. Biederman <ebiederm@xmission.com>
Sat, 4 Jul 2020 14:34:06 +0000 (09:34 -0500)
commitb044fa2ae50d52d8c9f9d130055c2aea032e7475
tree57ee270a4029458c3e233dd2bf82cfb9c74f01c9
parent5fec25f2cb959cb5f189d7f6127bee3efc782530
umh: Move setting PF_UMH into umh_pipe_setup

I am separating the code specific to user mode drivers from the code
for ordinary user space helpers.  Move setting of PF_UMH from
call_usermodehelper_exec_async which is core user mode helper code
into umh_pipe_setup which is user mode driver code.

The code is equally as easy to write in one location as the other and
the movement minimizes the impact of the user mode driver code on the
core of the user mode helper code.

Setting PF_UMH unconditionally is harmless as an action will only
happen if it is paired with an entry on umh_list.

v1: https://lkml.kernel.org/r/87bll6gf8t.fsf_-_@x220.int.ebiederm.org
v2: https://lkml.kernel.org/r/87zh8l63xs.fsf_-_@x220.int.ebiederm.org
Link: https://lkml.kernel.org/r/20200702164140.4468-2-ebiederm@xmission.com
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Tested-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
kernel/umh.c