]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
HID: nvidia-shield: Fix a missing led_classdev_unregister() in the probe error handli...
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 18 Sep 2023 11:54:30 +0000 (04:54 -0700)
committerJiri Kosina <jkosina@suse.cz>
Thu, 5 Oct 2023 10:50:34 +0000 (12:50 +0200)
commitb07b6b27a50e3a740c9aa6260ee4bb3ab29515ab
treeb30dbc317ece333430c11aed0d28f9487f0d71f5
parent1437e4547edf41689d7135faaca4222ef0081bc1
HID: nvidia-shield: Fix a missing led_classdev_unregister() in the probe error handling path

The commit in Fixes updated the error handling path of
thunderstrike_create() and the remove function but not the error handling
path of shield_probe(), should an error occur after a successful
thunderstrike_create() call.

Add the missing call. Make sure it is safe to call in the probe error
handling path by preventing the led_classdev from attempting to set the LED
brightness to the off state on unregister.

Fixes: f88af60e74a5 ("HID: nvidia-shield: Support LED functionality for Thunderstrike")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-nvidia-shield.c