]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
xfrm: don't call xfrm_policy_cache_flush while holding spinlock
authorFlorian Westphal <fw@strlen.de>
Sat, 6 Jan 2018 00:13:08 +0000 (01:13 +0100)
committerSteffen Klassert <steffen.klassert@secunet.com>
Mon, 8 Jan 2018 09:16:40 +0000 (10:16 +0100)
commitb1bdcb59b64f806ef08d25a85c39ffb3ad841ce6
treec860622d60b86a1ee0a7344a34e296a33061b94a
parentbcfd09f7837f5240c30fd2f52ee7293516641faa
xfrm: don't call xfrm_policy_cache_flush while holding spinlock

xfrm_policy_cache_flush can sleep, so it cannot be called while holding
a spinlock.  We could release the lock first, but I don't see why we need
to invoke this function here in first place, the packet path won't reuse
an xdst entry unless its still valid.

While at it, add an annotation to xfrm_policy_cache_flush, it would
have probably caught this bug sooner.

Fixes: ec30d78c14a813 ("xfrm: add xdst pcpu cache")
Reported-by: syzbot+e149f7d1328c26f9c12f@syzkaller.appspotmail.com
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_policy.c