]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
scsi: ufs: Fix imprecise load calculation in devfreq window
authorStanley Chu <stanley.chu@mediatek.com>
Thu, 11 Jun 2020 10:10:43 +0000 (18:10 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Jun 2020 03:39:00 +0000 (23:39 -0400)
commitb1bf66d1d5a8fcb54f0e584db5d196ef015b5172
tree0095d2001cb8c9c9819727070ebca18852a64937
parentaa5c697988b4c7e1077de1e2eb2298114d531736
scsi: ufs: Fix imprecise load calculation in devfreq window

The UFS load calculation is based on "total_time" and "busy_time" in a
devfreq window.  However, the source of time is different for both
parameters: "busy_time" is assigned from "jiffies" thus has different
accuracy from "total_time" which is assigned from ktime_get().

In addition, the time of window boundary is not exactly the same as the
starting busy time in this window if UFS is actually busy in the beginning
of the window. A similar accuracy error may also happen for the end of busy
time in current window.

To guarantee the precision of load calculation, we need to

1. Align time accuracy of both devfreq_dev_status.total_time and
   devfreq_dev_status.busy_time. For example, use "ktime_get()" directly.

2. Align the following timelines:
   - The beginning time of devfreq windows
   - The beginning of busy time in a new window
   - The end of busy time in the current window

Link: https://lore.kernel.org/r/20200611101043.6379-1-stanley.chu@mediatek.com
Fixes: a3cd5ec55f6c ("scsi: ufs: add load based scaling of UFS gear")
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c
drivers/scsi/ufs/ufshcd.h