]> git.proxmox.com Git - qemu.git/commit
stream: fix ratelimiting corner case
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 8 May 2012 14:51:57 +0000 (16:51 +0200)
committerKevin Wolf <kwolf@redhat.com>
Thu, 10 May 2012 09:01:59 +0000 (11:01 +0200)
commitb21d677ee9efe431a4acc653a8cfb12650e44cec
treec85f6f806652eac1c8eaf2974a858973ff520cdf
parentc6db23958bdbeaba6877a0b16d9977b6b09f8744
stream: fix ratelimiting corner case

This fixes inability to make progress in streaming if the quota is set
to less than the amount of data that an I/O operation has to write.

In this case, limit->dispatched + n will always be above the quota and,
due to the "goto retry" to recheck cancellation and allocation, streaming
will livelock.

This can be reproduced with "block_job_set_speed ide0-hd0 1b".  Of course,
with this patch the requested limit will not be obeyed.  That could be
done with another patch that caps is_allocated's n argument by the slice
quota.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/stream.c