]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
batman-adv: Avoid probe ELP information leak
authorSven Eckelmann <sven@narfation.org>
Fri, 31 Aug 2018 13:08:44 +0000 (15:08 +0200)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:54:14 +0000 (19:54 -0600)
commitb22bc5069fd27164930d6af22584ff59a486ed91
tree1d912a005284835d09206f695c318492781e2fa2
parentf05c39fc2c9a9eab10229bf1996f5f373077f080
batman-adv: Avoid probe ELP information leak

BugLink: https://bugs.launchpad.net/bugs/1836654
[ Upstream commit 88d0895d0ea9d4431507d576c963f2ff9918144d ]

The probe ELPs for WiFi interfaces are expanded to contain at least
BATADV_ELP_MIN_PROBE_SIZE bytes. This is usually a lot more than the
number of bytes which the template ELP packet requires.

These extra padding bytes were not initialized and thus could contain data
which were previously stored at the same location. It is therefore required
to set it to some predefined or random values to avoid leaking private
information from the system transmitting these kind of packets.

Fixes: e4623c913508 ("batman-adv: Avoid probe ELP information leak")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Acked-by: Antonio Quartulli <a@unstable.cc>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
net/batman-adv/bat_v_elp.c