]> git.proxmox.com Git - mirror_qemu.git/commit
qapi: Drop support for boxed alternate arguments
authorMarkus Armbruster <armbru@redhat.com>
Fri, 13 Sep 2019 20:13:36 +0000 (22:13 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 24 Sep 2019 12:07:22 +0000 (14:07 +0200)
commitb22e86585b296b254209cdc7011fcc74dd08717d
treed9298e147c17bcfbb6a664d5fa4a178cf5bab5ed
parentdcca907bed4707f8fa8bbfdd9eef741fdaad29f8
qapi: Drop support for boxed alternate arguments

Commands and events can define their argument type inline (default) or
by referring to another type ('boxed': true, since commit c818408e44
"qapi: Implement boxed types for commands/events", v2.7.0).  The
unboxed inline definition is an (anonymous) struct type.  The boxed
type may be a struct, union, or alternate type.

The latter is problematic: docs/interop/qemu-spec.txt requires the
value of the 'data' key to be a json-object, but any non-degenerate
alternate type has at least one branch that isn't.

Fortunately, we haven't made use of alternates in this context outside
tests/.  Drop support for them.

QAPISchemaAlternateType.is_empty() is now unused.  Drop it, too.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190913201349.24332-4-armbru@redhat.com>
docs/devel/qapi-code-gen.txt
scripts/qapi/common.py
tests/qapi-schema/qapi-schema-test.json
tests/qapi-schema/qapi-schema-test.out