]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
x86/amd_nb: Fix boot crash on non-AMD systems
authorBorislav Petkov <bp@suse.de>
Thu, 16 Jun 2016 17:13:49 +0000 (19:13 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 9 Aug 2016 13:08:00 +0000 (15:08 +0200)
commitb2cdb09920dc06aa169f6926fa6eb1f72e88c92f
tree22317539a168d73237069c5c97c3612f01478202
parent65f7f3f54028a5b9d2195d035946a91c135a5293
x86/amd_nb: Fix boot crash on non-AMD systems

BugLink: http://bugs.launchpad.net/bugs/1607404
commit 1ead852dd88779eda12cb09cc894a03d9abfe1ec upstream.

Fix boot crash that triggers if this driver is built into a kernel and
run on non-AMD systems.

AMD northbridges users call amd_cache_northbridges() and it returns
a negative value to signal that we weren't able to cache/detect any
northbridges on the system.

At least, it should do so as all its callers expect it to do so. But it
does return a negative value only when kmalloc() fails.

Fix it to return -ENODEV if there are no NBs cached as otherwise, amd_nb
users like amd64_edac, for example, which relies on it to know whether
it should load or not, gets loaded on systems like Intel Xeons where it
shouldn't.

Reported-and-tested-by: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1466097230-5333-2-git-send-email-bp@alien8.de
Link: https://lkml.kernel.org/r/5761BEB0.9000807@cybernetics.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
arch/x86/kernel/amd_nb.c