]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Fri, 3 Sep 2021 07:35:43 +0000 (15:35 +0800)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Tue, 12 Oct 2021 22:31:45 +0000 (16:31 -0600)
commitb2dbe08f53ec85016fe7cd8f2e7872996743bfd6
treefbab86c9131ac44ce053a7dbea5f3436f02c0c70
parent49ad37b4013b24d4f957cd75cab637e13baf4863
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom

BugLink: https://bugs.launchpad.net/bugs/1946802
[ Upstream commit 9ddbc2a00d7f63fa9748f4278643193dac985f2d ]

Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
in qlcnic_pinit_from_rom(), but remains its corresponding
unlock function, which is odd. I'm not very sure whether the
lock is missing, or the unlock is redundant. This bug is
suggested by a static analysis tool, please advise.

Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c