]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
usb: gadget: don't dereference g until after it has been null checked
authorColin Ian King <colin.king@canonical.com>
Tue, 14 Nov 2017 16:18:28 +0000 (16:18 +0000)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Tue, 28 Nov 2017 11:04:50 +0000 (13:04 +0200)
commitb2fc059fa549fe6881d4c1f8d698b0f50bcd16ec
tree179ab5772ba2175236fce42963f1e99fd8f3a1ae
parent593e789fd4421635bde09398b8a8fb510b18414a
usb: gadget: don't dereference g until after it has been null checked

Avoid dereferencing pointer g until after g has been sanity null checked;
move the assignment of cdev much later when it is required into a more
local scope.

Detected by CoverityScan, CID#1222135 ("Dereference before null check")

Fixes: b785ea7ce662 ("usb: gadget: composite: fix ep->maxburst initialization")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/composite.c