]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ASoC: SOF: imx: fix reverse CONFIG_SND_SOC_SOF_OF dependency
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 1 Nov 2019 17:30:39 +0000 (12:30 -0500)
committerSeth Forshee <seth.forshee@canonical.com>
Mon, 6 Jan 2020 14:16:10 +0000 (08:16 -0600)
commitb3d609dcb3a4c3d438b57e54eb25522772e7238b
treedf6920649df0c8579802752056f9986c16b04934
parentb33ff8755bcec50e5c0de0a8c6ffb9418cb4429f
ASoC: SOF: imx: fix reverse CONFIG_SND_SOC_SOF_OF dependency

BugLink: https://bugs.launchpad.net/bugs/1858428
[ Upstream commit f9ad75468453b019b92c5296e6a04bf7c37f49e4 ]

updated solution to the problem reported with randconfig:

CONFIG_SND_SOC_SOF_IMX depends on CONFIG_SND_SOC_SOF, but is in
turn referenced by the sof-of-dev driver. This creates a reverse
dependency that manifests in a link error when CONFIG_SND_SOC_SOF_OF
is built-in but CONFIG_SND_SOC_SOF_IMX=m:

sound/soc/sof/sof-of-dev.o:(.data+0x118): undefined reference to `sof_imx8_ops'

use def_trisate to propagate the right settings without select.

Fixes: f4df4e4042b0 ("ASoC: SOF: imx8: Fix COMPILE_TEST error")
Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support")
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20191101173045.27099-6-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
sound/soc/sof/imx/Kconfig