]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
arm: perf: Fix callchain parse error with kernel tracepoint events
authorHou Pengyang <houpengyang@huawei.com>
Fri, 8 May 2015 05:43:03 +0000 (06:43 +0100)
committerWill Deacon <will.deacon@arm.com>
Wed, 27 May 2015 15:12:05 +0000 (16:12 +0100)
commitb3eac0265bf6258f08dcd4ac7fa7f87cc050defc
tree5f3aef7fbf03d55801a9a53e368b6a369e3a8280
parentb787f68c36d49bb1d9236f403813641efa74a031
arm: perf: Fix callchain parse error with kernel tracepoint events

For ARM, when tracing with tracepoint events, the IP and cpsr are set
to 0, preventing the perf code parsing the callchain and resolving the
symbols correctly.

 ./perf record -e sched:sched_switch -g --call-graph dwarf ls
    [ perf record: Captured and wrote 0.006 MB perf.data ]
 ./perf report -f
    Samples: 5  of event 'sched:sched_switch', Event count (approx.): 5
    Children      Self    Command  Shared Object     Symbol
    100.00%       100.00%  ls       [unknown]         [.] 00000000

The fix is to implement perf_arch_fetch_caller_regs for ARM, which fills
several necessary registers used for callchain unwinding, including pc,sp,
fp and cpsr.

With this patch, callchain can be parsed correctly as :

   .....
-  100.00%   100.00%  ls       [kernel.kallsyms]  [k] __sched_text_start
   + __sched_text_start
+   20.00%     0.00%  ls       libc-2.18.so       [.] _dl_addr
+   20.00%     0.00%  ls       libc-2.18.so       [.] write
   .....

Jean Pihet found this in ARM and come up with a patch:
http://thread.gmane.org/gmane.linux.kernel/1734283/focus=1734280

This patch rewrite Jean's patch in C.

Signed-off-by: Hou Pengyang <houpengyang@huawei.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm/include/asm/perf_event.h