]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow
authorTim Gardner <tim.gardner@canonical.com>
Mon, 27 Sep 2021 15:45:02 +0000 (09:45 -0600)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:19:22 +0000 (15:19 +0200)
commitb423125e51e3d743264f8517c7b32de8a576f0d8
treecb29a995b60451290c3d715341fa92884366e23b
parent4e76be3b2e8473e10305b58c6de4c4a5c1162151
video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

BugLink: https://bugs.launchpad.net/bugs/1971497
[ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ]

Coverity complains of a possible buffer overflow. However,
given the 'static' scope of nvidia_setup_i2c_bus() it looks
like that can't happen after examiniing the call sites.

CID 19036 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
1. fixed_size_dest: You might overrun the 48-character fixed-size string
  chan->adapter.name by copying name without checking the length.
2. parameter_as_source: Note: This defect has an elevated risk because the
  source argument is a parameter of the current function.
 89        strcpy(chan->adapter.name, name);

Fix this warning by using strscpy() which will silence the warning and
prevent any future buffer overflows should the names used to identify the
channel become much longer.

Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/video/fbdev/nvidia/nv_i2c.c