]> git.proxmox.com Git - mirror_qemu.git/commit
arm/acpi: simplify the description of PCI _CRS
authorHeyi Guo <guoheyi@huawei.com>
Tue, 4 Feb 2020 01:43:24 +0000 (09:43 +0800)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 13 Feb 2020 14:14:53 +0000 (14:14 +0000)
commitb43bd40ba27c3a9ebd246f7294dc8983d96fe7e4
tree031889469dc0d02eaa2ed125042aeb7959880da8
parentf0ca15ad8954bad5baf8a7d5f625dd810616b53c
arm/acpi: simplify the description of PCI _CRS

The original code defines a named object for the resource template but
then returns the resource template object itself; the resulted output
is like below:

Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
{
    Name (RBUF, ResourceTemplate ()
    {
        WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
            0x0000,             // Granularity
            0x0000,             // Range Minimum
            0x00FF,             // Range Maximum
            0x0000,             // Translation Offset
            0x0100,             // Length
            ,, )
        ......
    })
    Return (ResourceTemplate ()
    {
        WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
            0x0000,             // Granularity
            0x0000,             // Range Minimum
            0x00FF,             // Range Maximum
            0x0000,             // Translation Offset
            0x0100,             // Length
            ,, )
        ......
    })
}

So the named object "RBUF" is actually useless. The more natural way
is to return RBUF instead, or simply drop RBUF definition.

Choose the latter one to simplify the code.

Signed-off-by: Heyi Guo <guoheyi@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 20200204014325.16279-7-guoheyi@huawei.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/virt-acpi-build.c