]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ALSA: sis7019: Fix the missing error handling
authorTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 10:26:24 +0000 (12:26 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:42:07 +0000 (14:42 +0200)
commitb43f8d7b77183252ddfff1e7ac1f48392ea81fb0
tree71eb376e2983f659ad1bdc0fb5cf6923bf97b57d
parent1563e4fa74049fd5e2203fc67ed22ab33a6f7586
ALSA: sis7019: Fix the missing error handling

BugLink: https://bugs.launchpad.net/bugs/1969857
commit 2236a3243ff8291e97c70097dd11a0fdb8904380 upstream.

The previous cleanup with devres forgot to replace the snd_card_free()
call with the devm version.  Moreover, it still needs the manual call
of snd_card_free() at the probe error path, otherwise the reverse
order of the releases may happen.  This patch addresses those issues.

Fixes: 499ddc16394c ("ALSA: sis7019: Allocate resources with device-managed APIs")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220412102636.16000-28-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/pci/sis7019.c