]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
aacraid: prevent invalid pointer dereference
authorMahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>
Thu, 31 Oct 2013 08:31:02 +0000 (14:01 +0530)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 20 Nov 2013 00:27:39 +0000 (16:27 -0800)
commitb4789b8e6be3151a955ade74872822f30e8cd914
tree070da93a2dea0db435ae935b90e73cb807440f79
parent1ee2dcc2245340cf4ac94b99c4d00efbeba61824
aacraid: prevent invalid pointer dereference

It appears that driver runs into a problem here if fibsize is too small
because we allocate user_srbcmd with fibsize size only but later we
access it until user_srbcmd->sg.count to copy it over to srbcmd.

It is not correct to test (fibsize < sizeof(*user_srbcmd)) because this
structure already includes one sg element and this is not needed for
commands without data.  So, we would recommend to add the following
(instead of test for fibsize == 0).

Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>
Reported-by: Nico Golde <nico@ngolde.de>
Reported-by: Fabian Yamaguchi <fabs@goesec.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/aacraid/commctrl.c