]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
NFS: Remove an incorrect revalidation in nfs4_update_changeattr_locked()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 8 Feb 2022 17:14:44 +0000 (12:14 -0500)
committerPaolo Pisati <paolo.pisati@canonical.com>
Mon, 7 Mar 2022 10:44:11 +0000 (11:44 +0100)
commitb47f7b5d8772151f6e940167811e4d4ad79aaac3
tree55b3155ff3b7b7c6dbd69e1aab5ee6786091fda4
parentfd85a78b8e22600deebda26c41098f57ffc7c588
NFS: Remove an incorrect revalidation in nfs4_update_changeattr_locked()

BugLink: https://bugs.launchpad.net/bugs/1963890
commit 9d047bf68fe8cdb4086deaf4edd119731a9481ed upstream.

In nfs4_update_changeattr_locked(), we don't need to set the
NFS_INO_REVAL_PAGECACHE flag, because we already know the value of the
change attribute, and we're already flagging the size. In fact, this
forces us to revalidate the change attribute a second time for no good
reason.
This extra flag appears to have been introduced as part of the xattr
feature, when update_changeattr_locked() was converted for use by the
xattr code.

Fixes: 1b523ca972ed ("nfs: modify update_changeattr to deal with regular files")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
fs/nfs/nfs4proc.c