]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
fbdev/efifb: Fix 16 color palette entry calculation
authorMax Staudt <mstaudt@suse.de>
Mon, 13 Jun 2016 17:15:59 +0000 (19:15 +0200)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 8 Nov 2016 16:45:20 +0000 (16:45 +0000)
commitb4d31e0321776c568ac1e8ee0838f792223bea61
treea6c6c885eb6d869128eb777ba9fba55954de42a0
parentc13beff9b5fea807fdb9c7fb115a49f3c06c7cef
fbdev/efifb: Fix 16 color palette entry calculation

BugLink: http://bugs.launchpad.net/bugs/1637510
commit d50b3f43db739f03fcf8c0a00664b3d2fed0496e upstream.

When using efifb with a 16-bit (5:6:5) visual, fbcon's text is rendered
in the wrong colors - e.g. text gray (#aaaaaa) is rendered as green
(#50bc50) and neighboring pixels have slightly different values
(such as #50bc78).

The reason is that fbcon loads its 16 color palette through
efifb_setcolreg(), which in turn calculates a 32-bit value to write
into memory for each palette index.
Until now, this code could only handle 8-bit visuals and didn't mask
overlapping values when ORing them.

With this patch, fbcon displays the correct colors when a qemu VM is
booted in 16-bit mode (in GRUB: "set gfxpayload=800x600x16").

Fixes: 7c83172b98e5 ("x86_64 EFI boot support: EFI frame buffer driver") # v2.6.24+
Signed-off-by: Max Staudt <mstaudt@suse.de>
Acked-By: Peter Jones <pjones@redhat.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/video/fbdev/efifb.c