]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
st: use noop_llseek() instead of default_llseek()
authorJan Blunck <jblunck@suse.de>
Wed, 26 May 2010 21:44:51 +0000 (14:44 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 27 May 2010 16:12:56 +0000 (09:12 -0700)
commitb4d878e23c7f574490ee4d6fd59ebd6819781dd1
treef35ae256020799c8725a6f3c802b90b7c19b8c44
parent889e5fbbc2da4f59d5f1e9b6172c5ff2b92d02c8
st: use noop_llseek() instead of default_llseek()

st_open() suggests that llseek() doesn't work: "We really want to do
nonseekable_open(inode, filp); here, but some versions of tar incorrectly
call lseek on tapes and bail out if that fails.  So we disallow pread()
and pwrite(), but permit lseeks."

Instead of using the fallback default_llseek() the driver should use
noop_llseek() which leaves the file->f_pos untouched but succeeds.

Signed-off-by: Jan Blunck <jblunck@suse.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Kai Makisara <Kai.Makisara@kolumbus.fi>
Cc: Willem Riede <osst@riede.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/st.c