]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
scsi: ufs: fix broken hba->outstanding_tasks
authorStanley Chu <stanley.chu@mediatek.com>
Mon, 19 Aug 2019 13:43:28 +0000 (21:43 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 29 Aug 2019 21:47:23 +0000 (17:47 -0400)
commitb557217c8475f40bc765ee20ff6b3b9124c8a4fe
tree0ccfab85356297a0f1dee056f97bd10ddd9398e6
parente8fd0b9f6f487820a05a46ce3ac4b5df11ad6799
scsi: ufs: fix broken hba->outstanding_tasks

Currently bits in hba->outstanding_tasks are cleared only after their
corresponding task management commands are successfully done by
__ufshcd_issue_tm_cmd().

If timeout happens in a task management command, its corresponding bit in
hba->outstanding_tasks will not be cleared until next task management
command with the same tag used successfully finishes.

This is wrong and can lead to some issues, like power issue.  For example,
ufshcd_release() and ufshcd_gate_work() will do nothing if
hba->outstanding_tasks is not zero even if both UFS host and devices are
actually idle.

Solution is referred from error handling of device commands: bits in
hba->outstanding_tasks shall be cleared regardless of their execution
results.

Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c