]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ASoC: cs42l42: Remove duplicate control for WNF filter frequency
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 3 Aug 2021 16:08:34 +0000 (17:08 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 24 Sep 2021 10:27:28 +0000 (12:27 +0200)
commitb59e735083df934f6d8a9d3cbb14428a8f76bbe3
treef55538d423b8b89ee0390052895021ac0553950e
parentfc94fead348d00f495947642c42a15bba1a8fb81
ASoC: cs42l42: Remove duplicate control for WNF filter frequency

BugLink: https://bugs.launchpad.net/bugs/1944202
[ Upstream commit 8b353bbeae20e2214c9d9d88bcb2fda4ba145d83 ]

The driver was defining two ALSA controls that both change the same
register field for the wind noise filter corner frequency. The filter
response has two corners, at different frequencies, and the duplicate
controls most likely were an attempt to be able to set the value using
either of the frequencies.

However, having two controls changing the same field can be problematic
and it is unnecessary. Both frequencies are related to each other so
setting one implies exactly what the other would be.

Removing a control affects user-side code, but there is currently no
known use of the removed control so it would be best to remove it now
before it becomes a problem.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 2c394ca79604 ("ASoC: Add support for CS42L42 codec")
Link: https://lore.kernel.org/r/20210803160834.9005-2-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
sound/soc/codecs/cs42l42.c