]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
pinctrl: mvebu: Fix i2c sda definition for 98DX3236
authorChris Packham <chris.packham@alliedtelesis.co.nz>
Mon, 7 Sep 2020 21:17:10 +0000 (09:17 +1200)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 9 Nov 2020 13:48:11 +0000 (14:48 +0100)
commitb5c7fe18e5b81aeffbdb7253d8f2845504a49d3f
treeee46f3b94871a6bcf55375d7bb1cf613398c3ce5
parent86fb9ebdc10346b992e529b6bfd78a3e3f297197
pinctrl: mvebu: Fix i2c sda definition for 98DX3236

BugLink: https://bugs.launchpad.net/bugs/1900632
[ Upstream commit 63c3212e7a37d68c89a13bdaebce869f4e064e67 ]

Per the datasheet the i2c functions use MPP_Sel=0x1. They are documented
as using MPP_Sel=0x4 as well but mixing 0x1 and 0x4 is clearly wrong. On
the board tested 0x4 resulted in a non-functioning i2c bus so stick with
0x1 which works.

Fixes: d7ae8f8dee7f ("pinctrl: mvebu: pinctrl driver for 98DX3236 SoC")
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20200907211712.9697-2-chris.packham@alliedtelesis.co.nz
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Ian May <ian.may@canonical.com>
drivers/pinctrl/mvebu/pinctrl-armada-xp.c