]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
VME: restore bus_remove function causing incomplete module unload
authorStefano Babic <sbabic@denx.de>
Fri, 20 Jan 2017 15:38:20 +0000 (10:38 -0500)
committerTim Gardner <tim.gardner@canonical.com>
Mon, 13 Mar 2017 21:20:54 +0000 (15:20 -0600)
commitb5c96bbf3f53296edb0638a0749fee0da5566d92
treea59e851ae7ed7f590b1bfadd60c80ded1fc2196c
parent37b12423ce31da3e4ed56e73e00fc1ab71399cce
VME: restore bus_remove function causing incomplete module unload

BugLink: http://bugs.launchpad.net/bugs/1672544
commit 9797484ba83d68f18fe1cbd964b7cd830f78f0f7 upstream.

Commit 050c3d52cc7810d9d17b8cd231708609af6876ae ("vme: make core
vme support explicitly non-modular") dropped the remove function
because it appeared as if it was for removal of the bus, which is
not supported.

However, vme_bus_remove() is called when a VME device is removed
from the bus and not when the bus is removed; as it calls the VME
device driver's cleanup function.  Without this function, the
remove() in the VME device driver is never called and VME device
drivers cannot be reloaded again.

Here we restore the remove function that was deleted in that
commit, and the reference to the function in the bus structure.

Fixes: 050c3d52cc78 ("vme: make core vme support explicitly non-modular")
Cc: Manohar Vanga <manohar.vanga@gmail.com>
Acked-by: Martyn Welch <martyn@welchs.me.uk>
Cc: devel@driverdev.osuosl.org
Signed-off-by: Stefano Babic <sbabic@denx.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/vme/vme.c