]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
watchdog: da9062: No need to ping manually before setting timeout
authorStefan Riedmueller <s.riedmueller@phytec.de>
Fri, 3 Apr 2020 13:07:28 +0000 (15:07 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Sat, 8 Aug 2020 05:53:12 +0000 (01:53 -0400)
commitb5dacbd659092bd33804db4968667e59ad2e11a7
treef3a86db9174cfa4ba65db47a1ae65fe18ca3d5ac
parent8da5fb89bbe1490212ae32273a9dade8e92dc230
watchdog: da9062: No need to ping manually before setting timeout

BugLink: https://bugs.launchpad.net/bugs/1885322
[ Upstream commit a0948ddba65f4f6d3cfb5e2b84685485d0452966 ]

There is actually no need to ping the watchdog before disabling it
during timeout change. Disabling the watchdog already takes care of
resetting the counter.

This fixes an issue during boot when the userspace watchdog handler takes
over and the watchdog is already running. Opening the watchdog in this case
leads to the first ping and directly after that without the required
heartbeat delay a second ping issued by the set_timeout call. Due to the
missing delay this resulted in a reset.

Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Link: https://lore.kernel.org/r/20200403130728.39260-3-s.riedmueller@phytec.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/watchdog/da9062_wdt.c