]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: ena: fix: Free napi resources when ena_up() fails
authorSameeh Jubran <sameehj@amazon.com>
Wed, 1 May 2019 13:47:05 +0000 (16:47 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 13 Nov 2019 17:07:36 +0000 (18:07 +0100)
commitb64df276b959bcf4ddfc571d69e89748a8f1beab
tree68f6284e2400892c02a541846f258ecff976e2b4
parentf44255312bc8d14a6d82c2142b5ae69848f57bcb
net: ena: fix: Free napi resources when ena_up() fails

BugLink: https://bugs.launchpad.net/bugs/1850175
ena_up() calls ena_init_napi() but does not call ena_del_napi() in
case of failure. This causes a segmentation fault upon rmmod when
netif_napi_del() is called. Fix this bug by calling ena_del_napi()
before returning error from ena_up().

Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit b287cdbd1cedfc9606682c6e02b58d00ff3a33ae)
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Khaled Elmously <khalid.elmously@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/ethernet/amazon/ena/ena_netdev.c