]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
genetlink: clean up family attributes allocations
authorCong Wang <xiyou.wangcong@gmail.com>
Fri, 12 Jun 2020 07:16:55 +0000 (00:16 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Jun 2020 21:05:08 +0000 (14:05 -0700)
commitb65ce380b754e77fbfdcfc83fd6e29c8ceedf431
tree8a3a04539dbdafe4336223edb3b5da5684efdf77
parent18dbd4cd9b8c957025cf90a3c50102b31bde14f7
genetlink: clean up family attributes allocations

genl_family_rcv_msg_attrs_parse() and genl_family_rcv_msg_attrs_free()
take a boolean parameter to determine whether allocate/free the family
attrs. This is unnecessary as we can just check family->parallel_ops.
More importantly, callers would not need to worry about pairing these
parameters correctly after this patch.

And this fixes a memory leak, as after commit c36f05559104
("genetlink: fix memory leaks in genl_family_rcv_msg_dumpit()")
we call genl_family_rcv_msg_attrs_parse() for both parallel and
non-parallel cases.

Fixes: c36f05559104 ("genetlink: fix memory leaks in genl_family_rcv_msg_dumpit()")
Reported-by: Ido Schimmel <idosch@idosch.org>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/genetlink.c