]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
tcp/dccp: remove obsolete WARN_ON() in icmp handlers
authorEric Dumazet <edumazet@google.com>
Thu, 17 Mar 2016 05:52:15 +0000 (22:52 -0700)
committerTim Gardner <tim.gardner@canonical.com>
Thu, 21 Apr 2016 13:20:28 +0000 (07:20 -0600)
commitb6984ca8bf3f9c197217123a016cc7a3bb3c659a
tree72df55fabbf2f5d93223938242f207ffd879c9c7
parentdbeaa580c0f943bd6906ba7569d7ce487bbf72ba
tcp/dccp: remove obsolete WARN_ON() in icmp handlers

BugLink: http://bugs.launchpad.net/bugs/1573034
[ Upstream commit e316ea62e3203d524ff0239a40c56d3a39ad1b5c ]

Now SYN_RECV request sockets are installed in ehash table, an ICMP
handler can find a request socket while another cpu handles an incoming
packet transforming this SYN_RECV request socket into an ESTABLISHED
socket.

We need to remove the now obsolete WARN_ON(req->sk), since req->sk
is set when a new child is created and added into listener accept queue.

If this race happens, the ICMP will do nothing special.

Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Ben Lazarus <blazarus@google.com>
Reported-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
net/dccp/ipv4.c
net/ipv4/tcp_ipv4.c