]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
NFS: Ensure we revalidate attributes before using execute_ok()
authorTrond Myklebust <trond.myklebust@primarydata.com>
Tue, 29 Dec 2015 00:30:05 +0000 (19:30 -0500)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Tue, 27 Jun 2017 13:16:32 +0000 (10:16 -0300)
commitb6d8cc651e42df2f28e22ed36169e1759cb57056
treedac2496e38a2056ed7dc7e410399fe3967e62548
parent8998d9c65415b12418d0d962214ad5f3dc5e000c
NFS: Ensure we revalidate attributes before using execute_ok()

BugLink: http://bugs.launchpad.net/bugs/1698799
commit 5c5fc09a1157a11dbe84e6421c3e0b37d05238cb upstream.

Donald Buczek reports that NFS clients can also report incorrect
results for access() due to lack of revalidation of attributes
before calling execute_ok().
Looking closely, it seems chdir() is afflicted with the same problem.

Fix is to ensure we call nfs_revalidate_inode_rcu() or
nfs_revalidate_inode() as appropriate before deciding to trust
execute_ok().

Reported-by: Donald Buczek <buczek@molgen.mpg.de>
Link: http://lkml.kernel.org/r/1451331530-3748-1-git-send-email-buczek@molgen.mpg.de
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
fs/nfs/dir.c