]> git.proxmox.com Git - qemu.git/commit
hw/openrisc: Avoid using uninitialised variable 'entry'
authorJia Liu <proljc@gmail.com>
Wed, 21 Aug 2013 00:54:29 +0000 (08:54 +0800)
committerJia Liu <proljc@gmail.com>
Wed, 21 Aug 2013 01:15:36 +0000 (09:15 +0800)
commitb6d9766ddf5453e79e0c66c9348728ba44ba115f
tree9aee8b24e256b289cfbf95427131ebc51c94d64d
parentecfe10c9a6f9bc77d0e4b7eb5d0f5d61e8fbaed8
hw/openrisc: Avoid using uninitialised variable 'entry'

clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized:

hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used uninitialized
whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized]

    if (kernel_filename && !qtest_enabled()) {
        ^~~~~~~~~~~~~~~
hw/openrisc/openrisc_sim.c:91:19: note: uninitialized use occurs here
    cpu->env.pc = entry;
                  ^~~~~

Fix this by not attempting to change the CPU's starting PC unless
we actually loaded a kernel.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Jia Liu <proljc@gmail.com>
hw/openrisc/openrisc_sim.c