]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/i915: Wait for pipe to start before sampling vblank timestamps on gen2
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 14 Dec 2015 16:23:43 +0000 (18:23 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 12 Jan 2016 14:10:57 +0000 (16:10 +0200)
commitb7792d8b54cc0e66b94d625d70761d086cad1dd3
treee18ba9c53318fd9e10e8b718c5fad7b5db6fb35c
parent7d3fdfff23852fe458a0d0979a3555fe60f1e563
drm/i915: Wait for pipe to start before sampling vblank timestamps on gen2

We use the vblank timestamps to generate the vblank frame counter value
on gen2. That means we need the pipe scanout position to be accurate
when we call drm_crtc_vblank_on(), otherwise the frame counter
guesstimate may jump when the pipe actually start.

What I observed on my 85x is that the DSL initially reads 0, and when
the pipe actually starts DSL jumps to vblank_start. On gen2 DSL==0 means
actually vtotal-1 (see update_scanline_offset()), so if we initially
get vtotal-1, and then very quickly vblank_start (or thereabouts), the
scanout position will appear to jump backwards by approximately one
vblank length. Which means the frame counter guesstimate will also
jump backwards. That's no good, so let's make sure the pipe has
started before we call drm_crtc_vblank_on().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1450110229-30450-5-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c