]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
ftrace/x86_32: Set ftrace_stub to weak to prevent gcc from using short jumps to it
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Mon, 9 Jan 2017 14:34:29 +0000 (14:34 +0000)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 10 Jan 2017 17:43:21 +0000 (17:43 +0000)
commitb7fc9e853b0755cb735e1cb42c5517ea585e68fe
tree4440a0c73576c7c15c85e8c42bf7ab3584503104
parentcba0dd190b67962732e585ea1fa1ceb9b3ea35db
ftrace/x86_32: Set ftrace_stub to weak to prevent gcc from using short jumps to it

BugLink: http://bugs.launchpad.net/bugs/1655040
With new binutils, gcc may get smart with its optimization and change a jmp
from a 5 byte jump to a 2 byte one even though it was jumping to a global
function. But that global function existed within a 2 byte radius, and gcc
was able to optimize it. Unfortunately, that jump was also being modified
when function graph tracing begins. Since ftrace expected that jump to be 5
bytes, but it was only two, it overwrote code after the jump, causing a
crash.

This was fixed for x86_64 with commit 8329e818f149, with the same subject as
this commit, but nothing was done for x86_32.

Cc: stable@vger.kernel.org
Fixes: d61f82d06672 ("ftrace: use dynamic patching for updating mcount calls")
Reported-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
(cherry picked from commit 847fa1a6d3d00f3bdf68ef5fa4a786f644a0dd67)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
arch/x86/entry/entry_32.S