]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ASoC: soc-compress: prevent the potentially use of null pointer
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Fri, 15 Oct 2021 08:13:53 +0000 (08:13 +0000)
committerAndrea Righi <andrea.righi@canonical.com>
Thu, 9 Mar 2023 14:57:36 +0000 (15:57 +0100)
commitb821380f8009b6c724aa794bc7a598680d224df9
tree34d192444bddb61594721d5b5aa1b3c026a518c4
parent80a001878ce963b744faac390a2052b02a3da04c
ASoC: soc-compress: prevent the potentially use of null pointer

BugLink: https://bugs.launchpad.net/bugs/1968984
[ Upstream commit de2c6f98817fa5decb9b7d3b3a8a3ab864c10588 ]

There is one call trace that snd_soc_register_card()
->snd_soc_bind_card()->soc_init_pcm_runtime()
->snd_soc_dai_compress_new()->snd_soc_new_compress().
In the trace the 'codec_dai' transfers from card->dai_link,
and we can see from the snd_soc_add_pcm_runtime() in
snd_soc_bind_card() that, if value of card->dai_link->num_codecs
is 0, then 'codec_dai' could be null pointer caused
by index out of bound in 'asoc_rtd_to_codec(rtd, 0)'.
And snd_soc_register_card() is called by various platforms.
Therefore, it is better to add the check in the case of misusing.
And because 'cpu_dai' has already checked in soc_init_pcm_runtime(),
there is no need to check again.
Adding the check as follow, then if 'codec_dai' is null,
snd_soc_new_compress() will not pass through the check
'if (playback + capture != 1)', avoiding the leftover use of
'codec_dai'.

Fixes: 467fece ("ASoC: soc-dai: move snd_soc_dai_stream_valid() to soc-dai.c")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/1634285633-529368-1-git-send-email-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
sound/soc/soc-compress.c